Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds some tables to information_schema #2935

Merged

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Dec 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Part of #2931

Main changes:

  • Adds engines, column_privileges and column_statistics to information_schema.
  • Impl some helper functions and macros to add tables for information_schema.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2931

@killme2008 killme2008 changed the title feat: adds engines table to information_schema feat: adds some tables to information_schema Dec 15, 2023
@killme2008 killme2008 marked this pull request as ready for review December 15, 2023 06:46
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #2935 (a9a3175) into develop (d3da128) will decrease coverage by 0.55%.
Report is 6 commits behind head on develop.
The diff coverage is 91.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2935      +/-   ##
===========================================
- Coverage    85.13%   84.58%   -0.55%     
===========================================
  Files          752      756       +4     
  Lines       119411   119952     +541     
===========================================
- Hits        101658   101467     -191     
- Misses       17753    18485     +732     

@shuiyisong
Copy link
Contributor

shuiyisong commented Dec 15, 2023

impl SystemCatalog {

We might need to add new memory table names to table_names() and table_exist() in SystemCatalog so that they are displayed on show tables

@killme2008
Copy link
Contributor Author

impl SystemCatalog {

We might need to add new memory table names to table_names() and table_exist() in SystemCatalog so that they are displayed on show tables

OMG, good catch! Let me find some way to make it more readable.

@killme2008
Copy link
Contributor Author

@waynexia @shuiyisong PTAL

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 18, 2023
Merged via the queue into GreptimeTeam:develop with commit 262a79a Dec 18, 2023
13 checks passed
@killme2008 killme2008 deleted the feature/internal-tables branch December 19, 2023 06:12
@killme2008 killme2008 mentioned this pull request Dec 19, 2023
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants