Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade pgwire to 0.18 for corrected statement caching #3010

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Dec 26, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This patch upgrades pgwire to 0.18 which corrected implementation of prepared statement caching sunng87/pgwire#140. The statements are now cached with client and dropped when client disconnected.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@sunng87 sunng87 added the docs-not-required This change does not impact docs. label Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c5c755) 85.67% compared to head (bc4b522) 85.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3010      +/-   ##
===========================================
- Coverage    85.67%   85.16%   -0.51%     
===========================================
  Files          784      784              
  Lines       126824   126820       -4     
===========================================
- Hits        108651   108007     -644     
- Misses       18173    18813     +640     

@github-actions github-actions bot added docs-required This change requires docs update. docs-not-required This change does not impact docs. and removed docs-not-required This change does not impact docs. docs-required This change requires docs update. labels Dec 26, 2023
@waynexia waynexia removed the docs-not-required This change does not impact docs. label Dec 26, 2023
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 26, 2023
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Dec 27, 2023
Merged via the queue into GreptimeTeam:develop with commit feec4e2 Dec 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants