Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logs for upgrading candidate region and updating metadata #3077

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add logs for (region server) upgrading candidate region
Add logs for (procedure) updating metadata

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S and removed docs-not-required This change does not impact docs. labels Jan 3, 2024
@WenyXu WenyXu added the docs-not-required This change does not impact docs. label Jan 3, 2024
@WenyXu WenyXu self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c66ce6) 85.66% compared to head (7ee16d9) 85.17%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3077      +/-   ##
==========================================
- Coverage   85.66%   85.17%   -0.50%     
==========================================
  Files         805      805              
  Lines      130889   130954      +65     
==========================================
- Hits       112132   111539     -593     
- Misses      18757    19415     +658     

@WenyXu WenyXu requested a review from killme2008 January 3, 2024 07:03
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@WenyXu WenyXu mentioned this pull request Jan 3, 2024
39 tasks
@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2024
@evenyag evenyag added this pull request to the merge queue Jan 4, 2024
Merged via the queue into GreptimeTeam:main with commit 284a496 Jan 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants