fix(kafka): overwrite the EntryId with Offset while consuming records #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
fix/incorrect-entry-id
branch
from
7826d80
to
20045a3
Compare
WenyXu
changed the title
niebayes
approved these changes
Jan 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
- Coverage 85.41% 84.92% -0.49%
==========================================
Files 823 823
Lines 134797 134927 +130
==========================================
- Hits 115138 114592 -546
- Misses 19659 20335 +676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
We don't rely on the EntryId generated by mito2. Instead, we use the offset return from Kafka as EntryId. Therefore, we MUST overwrite the EntryId with RecordOffset.
Checklist
Refer to a related PR or issue link (optional)
#2700