Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update datafusion #3554

Conversation

MichaelScofield
Copy link
Collaborator

@MichaelScofield MichaelScofield commented Mar 21, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

pre-work to #3520

What's changed and what's your intention?

Old version of datafusion cannot rewrite TableScan plan with different table source: it uses plan equality to determine whether the rewrite is happened, while the table source field of TableScan plan is not considered in eq.

This PR also updates the "friends" of datafusion, including Arrow (to version 51), Parquet, sqlparser and tonic.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 21, 2024
@MichaelScofield MichaelScofield force-pushed the chore/update-datafusion branch 3 times, most recently from d75f403 to 7ca3477 Compare March 22, 2024 02:30
@sunng87
Copy link
Member

sunng87 commented Mar 22, 2024

Can we wait for arrow 51 release to include an update of tonic 0.11 which includes an update of rustls 0.22? I think it won't be long.

@evenyag
Copy link
Contributor

evenyag commented Mar 25, 2024

Can we wait for arrow 51 release to include an update of tonic 0.11 which includes an update of rustls 0.22? I think it won't be long.

https://github.com/apache/arrow-datafusion/blob/bd9b33ceca3553431b6b328de93f1836bbd9e263/Cargo.toml#L60

Datafusion already upgrades to arrow 51. arrow 51 also contains some useful features we might use later.

@waynexia
Copy link
Member

Can we wait for arrow 51 release to include an update of tonic 0.11 which includes an update of rustls 0.22? I think it won't be long.

I'm Okay with this update PR. I can do another update later when it's released. This patch has contained lots of change

@MichaelScofield MichaelScofield force-pushed the chore/update-datafusion branch 2 times, most recently from 3d0ad5d to 6247ba3 Compare March 27, 2024 11:38
@MichaelScofield MichaelScofield force-pushed the chore/update-datafusion branch 4 times, most recently from b7a1a5d to 069b3a9 Compare March 29, 2024 11:27
@MichaelScofield MichaelScofield marked this pull request as ready for review March 29, 2024 11:35
@MichaelScofield

This comment was marked as outdated.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 78.01684% with 235 lines in your changes are missing coverage. Please review.

Project coverage is 84.82%. Comparing base (2ede968) to head (03533ca).
Report is 3 commits behind head on main.

❗ Current head 03533ca differs from pull request most recent head 2a68b2f. Consider uploading reports for the commit 2a68b2f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3554      +/-   ##
==========================================
- Coverage   85.16%   84.82%   -0.34%     
==========================================
  Files         943      943              
  Lines      157235   157250      +15     
==========================================
- Hits       133911   133395     -516     
- Misses      23324    23855     +531     

@killme2008
Copy link
Contributor

killme2008 commented Mar 30, 2024

We can't merge this PR until we fix all these failed tests.

@MichaelScofield
Copy link
Collaborator Author

close because of #3661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants