-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update datafusion #3554
chore: update datafusion #3554
Conversation
d75f403
to
7ca3477
Compare
Can we wait for arrow 51 release to include an update of tonic 0.11 which includes an update of rustls 0.22? I think it won't be long. |
7ca3477
to
fc1fdf6
Compare
Datafusion already upgrades to arrow 51. arrow 51 also contains some useful features we might use later. |
I'm Okay with this update PR. I can do another update later when it's released. This patch has contained lots of change |
3d0ad5d
to
6247ba3
Compare
b7a1a5d
to
069b3a9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
069b3a9
to
e1a39d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 85.16% 84.82% -0.34%
==========================================
Files 943 943
Lines 157235 157250 +15
==========================================
- Hits 133911 133395 -516
- Misses 23324 23855 +531 |
We can't merge this PR until we fix all these failed tests. |
e1a39d6
to
9eb6c06
Compare
03533ca
to
e8f3201
Compare
e8f3201
to
2a68b2f
Compare
close because of #3661 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
pre-work to #3520
What's changed and what's your intention?
Old version of datafusion cannot rewrite TableScan plan with different table source: it uses plan equality to determine whether the rewrite is happened, while the table source field of TableScan plan is not considered in eq.
This PR also updates the "friends" of datafusion, including Arrow (to version 51), Parquet, sqlparser and tonic.
Checklist