-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flow): support datafusion scalar function #4142
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4142 +/- ##
==========================================
- Coverage 85.46% 84.60% -0.87%
==========================================
Files 994 1023 +29
Lines 174582 179538 +4956
==========================================
+ Hits 149204 151894 +2690
- Misses 25378 27644 +2266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit tests required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, we need some tests for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
support datafusion scalar function
Please explain IN DETAIL what the changes are in this PR and why they are needed:
support datafusion scalar function by let datafusion decode substrait proto, and hence build df
PhysicalExpr
to evaluate functionDfScalarFunction
which hold both impl of that scalar function and necessary data to ser/de itChecklist