-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump datafusion version to fix last_value
regression
#4169
chore: bump datafusion version to fix last_value
regression
#4169
Conversation
c7dfea8
to
76b0520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's better to add a sqlness test to https://github.com/GreptimeTeam/greptimedb/blob/main/tests/cases/standalone/common/function/expression.sql |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4169 +/- ##
==========================================
- Coverage 85.16% 84.83% -0.33%
==========================================
Files 1020 1020
Lines 179630 179635 +5
==========================================
- Hits 152976 152392 -584
- Misses 26654 27243 +589 |
This PR also fixed #4096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…meTeam#4169) * chore: bump datafusion version to fix `last_value` regression * fix: resolve PR comments * fix ci
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
... to the datafusion commit with PR apache/datafusion#10783.
Now
last_value
with string arg works:Also fix #4096 :
Checklist