-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: wait until checkpoint finish #4202
test: wait until checkpoint finish #4202
Conversation
WalkthroughA new loop has been added to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/mito2/src/manifest/tests/checkpoint.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- src/mito2/src/manifest/tests/checkpoint.rs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4202 +/- ##
==========================================
- Coverage 85.05% 84.76% -0.29%
==========================================
Files 1031 1031
Lines 181276 181276
==========================================
- Hits 154176 153657 -519
- Misses 27100 27619 +519 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4191
What's changed and what's your intention?
The checkpoint is done in the background so the checkpoint test may not corrupt the latest checkpoint. This PR waits until the checkpoint is finished.
Checklist
Summary by CodeRabbit