Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add AUTHOR.md file #4241

Merged
merged 1 commit into from
Jul 2, 2024
Merged

chore: add AUTHOR.md file #4241

merged 1 commit into from
Jul 2, 2024

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Jul 1, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

AS IS

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Summary by CodeRabbit

  • Documentation
    • Created AUTHOR.md with a list of individual committers and their GitHub profiles.
    • Updated CONTRIBUTING.md to reference the AUTHOR.md file for the list of current committers.
    • Added a special thanks message to contributors in README.md, with a link to AUTHOR.md.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from a team as a code owner July 1, 2024 21:51
Copy link
Contributor

coderabbitai bot commented Jul 1, 2024

Walkthrough

The changes involve three key files in the GreptimeDB repository: AUTHOR.md, CONTRIBUTING.md, and README.md. The AUTHOR.md file is newly created to list all contributors alphabetically, with their GitHub profiles. CONTRIBUTING.md is updated to reference AUTHOR.md for the list of committers, and README.md now includes a special thanks message to contributors, directing viewers to AUTHOR.md for more details.

Changes

Files Change Summary
AUTHOR.md New file listing individual committers and team members alphabetically, including their GitHub profiles. It also links to a section for all contributors on GitHub.
CONTRIBUTING.md Updated to replace the specific list of committers with a reference to AUTHOR.md.
README.md Added a special thanks message to contributors, pointing to AUTHOR.md for the detailed list of contributors.

Poem

Amidst our code and data streams,
New lists and thanks, it smoothly gleams.
Contributors praised in AUTHOR.md,
With GitHub links for all to see.
The README nods and winks with grace,
While CONtributing finds its place.
Thank you all, from CodeRabbit's den,
For building dreams with keyboard and pen.


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jul 1, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2665616 and c779027.

Files selected for processing (3)
  • AUTHOR.md (1 hunks)
  • CONTRIBUTING.md (1 hunks)
  • README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • AUTHOR.md
Additional context used
LanguageTool
CONTRIBUTING.md

[style] ~2-~2: ‘Thanks a lot’ is a rather informal expression of gratitude. Consider replacing it to add a more respectful tone to your message.
Context: # Welcome 👋 Thanks a lot for considering contributing to Greptim...

(THANKS_A_LOT)


[style] ~29-~29: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...r experience with GreptimeDB, or if you want to discuss any ideas, you can start a disc...

(REP_WANT_TO_VB)


[uncategorized] ~55-~55: Possible missing article found.
Context: ...power. ### Before PR - To ensure that community is free and confident in its ability to...

(AI_HYDRA_LEO_MISSING_THE)


[style] ~58-~58: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d style guide. - Make sure all unit tests are passed (using `...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~59-~59: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ....st/index.html) cargo nextest run). - Make sure all clippy warnings are fixed (you...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[grammar] ~63-~63: The word “setup” is a noun. The verb is spelled with a space.
Context: ...). #### pre-commit Hooks You could setup the [pre-commit`](https://pre-commit.c...

(NOUN_VERB_CONFUSION)


[style] ~93-~93: The phrase ‘feel free to’ is used quite frequently. Consider using a less frequent alternative to set your writing apart from others and make it sound more professional.
Context: ...pull request title. ### Description - Feel free to go brief if your pull request is small,...

(FEEL_FREE_TO_STYLE_ME)


[uncategorized] ~94-~94: Possible missing article found.
Context: ..., like a typo fix. - But if it contains large code change, make sure to state the mot...

(AI_HYDRA_LEO_MISSING_A)

Markdownlint
CONTRIBUTING.md

5-5: null
Bare URL used

(MD034, no-bare-urls)


25-25: null
Bare URL used

(MD034, no-bare-urls)

README.md

137-137: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


141-141: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


142-142: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


143-143: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


144-144: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


145-145: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


146-146: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


165-165: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


166-166: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


167-167: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


171-171: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


172-172: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


173-173: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


188-188: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


189-189: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


190-190: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


191-191: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


192-192: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

Additional comments not posted (3)
CONTRIBUTING.md (2)

7-7: Use a more formal expression of gratitude.

The phrase "Thanks a lot" is informal. Consider replacing it with "Thank you very much" to maintain a respectful tone.

- Thanks a lot for considering contributing to GreptimeDB.
+ Thank you very much for considering contributing to GreptimeDB.

7-7: Verify the link to AUTHOR.md.

Ensure that the AUTHOR.md file exists in the repository and the link is correct.

Verification successful

The link to AUTHOR.md in CONTRIBUTING.md is correct.

  • The AUTHOR.md file exists in the repository root.
  • The link syntax in CONTRIBUTING.md correctly points to AUTHOR.md.
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the existence of the AUTHOR.md file.
# Test: Check if the AUTHOR.md file exists in the repository root.

if [ ! -f "AUTHOR.md" ]; then
  echo "AUTHOR.md file is missing."
  exit 1
fi
echo "AUTHOR.md file exists."

Length of output: 81



Script:

#!/bin/bash
# Description: Verify the correctness of the link to AUTHOR.md in CONTRIBUTING.md
# Test: Check if the link syntax in CONTRIBUTING.md correctly points to AUTHOR.md

# Use grep to find the link syntax in CONTRIBUTING.md
grep -q "\[AUTHOR.md\](AUTHOR.md)" CONTRIBUTING.md

if [ $? -ne 0 ]; then
  echo "The link to AUTHOR.md in CONTRIBUTING.md is incorrect."
  exit 1
fi
echo "The link to AUTHOR.md in CONTRIBUTING.md is correct."

Length of output: 185

README.md (1)

186-186: Verify the link to AUTHOR.md.

Ensure that the AUTHOR.md file exists in the repository and the link is correct.

Verification successful

The AUTHOR.md file exists, and the link in the README.md is correct.

  • The link to AUTHOR.md in the README.md file is valid.
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the existence of the AUTHOR.md file.
# Test: Check if the AUTHOR.md file exists in the repository root.

if [ ! -f "AUTHOR.md" ]; then
  echo "AUTHOR.md file is missing."
  exit 1
fi
echo "AUTHOR.md file exists."

Length of output: 81

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit ea081c9 Jul 2, 2024
13 checks passed
@sunng87 sunng87 deleted the authors branch July 2, 2024 01:23
v0y4g3r pushed a commit to v0y4g3r/greptimedb that referenced this pull request Jul 3, 2024
Signed-off-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants