fix(ci): remove sqlness state in success #4313
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
WalkthroughThe primary updates involve improvements in handling temporary directories and SQL query adjustments for timestamp flexibility. Changes include an alteration to how the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Runner
participant Env
User->>Runner: Execute main function
Runner->>Runner: Obtain data_home using into_path()
Runner->>Env: Create new environment with data_home
Runner->>User: Process data
alt Preserve state
Runner->>User: Exit without removing data_home
else
Runner->>User: Print "Removing state"
Runner->>Runner: Remove data_home directory
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/runner/src/main.rs (2 hunks)
Additional comments not posted (5)
tests/runner/src/main.rs (5)
85-85: LGTM!The change to use
temp_dir.into_path()is appropriate and aligns with the new requirements for cleanup.
110-110: LGTM!Cloning
data_homeensures the original path is preserved for later use in cleanup.
115-115: LGTM!Inverting the condition aligns with the new requirement to remove the data directory unless
preserve_stateis explicitly set.
116-116: LGTM!The updated message correctly informs the user about the removal of the state directory.
117-117: LGTM!The change ensures that the temporary directory is cleaned up properly, preventing any leftover state from affecting future test runs. The use of
tokio::fs::remove_dir_allis appropriate for asynchronous directory removal.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4313 +/- ##
==========================================
- Coverage 85.11% 84.85% -0.27%
==========================================
Files 1060 1060
Lines 187648 187648
==========================================
- Hits 159720 159230 -490
- Misses 27928 28418 +490 |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- tests/cases/standalone/information_schema/cluster_info.result (2 hunks)
- tests/cases/standalone/information_schema/cluster_info.sql (2 hunks)
Files skipped from review due to trivial changes (1)
- tests/cases/standalone/information_schema/cluster_info.result
Additional comments not posted (3)
tests/cases/standalone/information_schema/cluster_info.sql (3)
8-8: LGTM!The updated regex pattern for
Start_timeis more flexible and should match various timestamp formats.
16-16: Consistent regex update forStart_time.The regex pattern update for
Start_timematches the change at line 8, ensuring consistency.
26-26: Consistent regex update forStart_time.The regex pattern update for
Start_timematches the changes at lines 8 and 16, ensuring consistency.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Change the
--preserve-statelogic to dump tempdir unconditionally and remove it in success. In case the log is cleaned on panic.Checklist
Summary by CodeRabbit
Bug Fixes
Start_timefield.Improvements