-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the unified artifacts manager #157
feat: add the unified artifacts manager #157
Conversation
Signed-off-by: zyy17 <zyylsxm@gmail.com>
Signed-off-by: zyy17 <zyylsxm@gmail.com>
Signed-off-by: zyy17 <zyylsxm@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #157 +/- ##
===========================================
+ Coverage 31.74% 34.54% +2.79%
===========================================
Files 10 10
Lines 1345 1297 -48
===========================================
+ Hits 427 448 +21
+ Misses 819 760 -59
+ Partials 99 89 -10
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed
Add the unified artifacts manager to manage charts and binaries(we will add plugins in the future);
REMOVE the old implementation of the artifacts manager;
Related issue: #151, #150.