Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use the latest version info to track latest artifacts of cn region #173

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 23, 2023

No description provided.

@zyy17 zyy17 force-pushed the refactor/use-latest-version-info branch from da3afce to ced080d Compare October 23, 2023 07:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 233 lines in your changes are missing coverage. Please review.

Comparison is base (076389d) 35.80% compared to head (cbaeefe) 34.48%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
- Coverage    35.80%   34.48%   -1.33%     
===========================================
  Files           12       16       +4     
  Lines         1430     1566     +136     
===========================================
+ Hits           512      540      +28     
- Misses         814      915     +101     
- Partials       104      111       +7     
Files Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/deployer/baremetal/deployer.go 30.42% <0.00%> (ø)
pkg/cluster/baremetal/validate.go 84.21% <84.21%> (ø)
pkg/cluster/baremetal/not_implemented.go 0.00% <0.00%> (ø)
pkg/cluster/baremetal/config.go 0.00% <0.00%> (ø)
pkg/artifacts/manager.go 53.21% <45.58%> (-1.82%) ⬇️
pkg/cluster/baremetal/cluster.go 0.00% <0.00%> (ø)
pkg/cluster/baremetal/get.go 12.87% <12.87%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyy17 zyy17 force-pushed the refactor/use-latest-version-info branch from 8eb2b87 to cbaeefe Compare October 23, 2023 10:09
@zyy17 zyy17 requested review from daviderli614 and shawnh2 and removed request for daviderli614 October 23, 2023 11:11
@shawnh2 shawnh2 merged commit 2817da1 into GreptimeTeam:develop Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants