Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reimplement delete cmd for cluster delete #179

Merged
merged 2 commits into from
Nov 1, 2023
Merged

refactor: reimplement delete cmd for cluster delete #179

merged 2 commits into from
Nov 1, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Nov 1, 2023

Fixes #155
Related to #160

@shawnh2
implement k8s delete api and decouple the set values config logic
9b3a6a8 
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2
implement bare-metal delete api
f208f62 
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from zyy17 November 1, 2023 08:59
@shawnh2 shawnh2 mentioned this pull request Nov 1, 2023
Closed
6 tasks
zyy17
zyy17 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17 zyy17 merged commit 412ad43 into GreptimeTeam:develop Nov 1, 2023
6 checks passed
@shawnh2 shawnh2 deleted the refactor/delete-cmd branch November 1, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No need to remove metadata when exit foreground bare-metal creation
2 participants
@shawnh2 @zyy17