Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change local artifact validation logic from tag to if blocks #183

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Nov 6, 2023

  • disable the SilenceErrors option, so the error from each cmd can surface
  • change artifact local fieldfile tag to filepath, only validate the file path, not existence
  • check file existence in codebase, and surface more readable error

Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from zyy17 November 6, 2023 07:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (42eaaba) 38.21% compared to head (7bb9cd5) 37.91%.

Files Patch % Lines
pkg/cluster/baremetal/create.go 0.00% 10 Missing ⚠️
pkg/plugins/manager.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
- Coverage    38.21%   37.91%   -0.30%     
===========================================
  Files           16       16              
  Lines         1285     1295      +10     
===========================================
  Hits           491      491              
- Misses         689      699      +10     
  Partials       105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17 zyy17 merged commit 6f534d2 into GreptimeTeam:develop Dec 27, 2023
6 checks passed
@shawnh2 shawnh2 deleted the fix-config-bm-start branch December 27, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants