examples: probe for -mtune=generic support, fix wrong LoongArch support #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loongson-zn
reviewed
Jul 22, 2021
examples/Makefile
Outdated
| OPT_CFLAGS = -Ofast | ||
| #endif | ||
| # Add -mtune=generic for GCC if supported. | ||
| NO_MTUNE_GENERIC = $(shell $(CXX) -mtune=generic -E - < /dev/null > /dev/null 2>&1; echo $?) |
There was a problem hiding this comment.
modify ‘echo
There was a problem hiding this comment.
Oops, nice catch. Fixed.
The commit being fixed is completely pointless, as it was introducing C preprocessor directives into a Makefile. That aside, there certainly are some GCC ports that does not have support for `-mtune=generic`, so probe for support dynamically instead. Fixes: f1996f1 ("delete -mtune option on loongarch architecture")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit being fixed is completely pointless, as it was introducing C
preprocessor directives into a Makefile. That aside, there certainly are
some GCC ports that does not have support for
-mtune=generic, so probefor support dynamically instead.
Fixes: f1996f1 ("delete -mtune option on loongarch architecture")
P.S. I came across that PR just by coincidence, I haven't looked at properly testing the library yet. Do exercise caution if you're going to directly merge this; I will try to verify the changes on actual LoongArch hardware in a day or so.