Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/literal parametrized dtype #1139

Merged

Conversation

FlorianDeconinck
Copy link
Contributor

@FlorianDeconinck FlorianDeconinck commented Jan 25, 2023

Description

In order to run a 32-bit float version of the model, we need at minima to be able to control literal dtype. This PR implements option 4 of the gtscript concept workshop

Requirements

Before submitting this PR, please make sure:

  • You have run the code checks, tests and documentation build successfully
  • All fixes and all new functionality are tested and documentation is up to date
  • You looked at the review checklist

Additionally, if this PR contains code authored by new contributors:

  • All the authors are covered by a valid contributor assignment agreement,
    signed by the employer if needed, provided to ETH Zurich

Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking the merge, until we have a new CAA.

@gronerl
Copy link
Contributor

gronerl commented Jan 26, 2023

bors try

bors bot added a commit that referenced this pull request Jan 26, 2023
@bors
Copy link

bors bot commented Jan 28, 2023

try

Timed out.

@gronerl
Copy link
Contributor

gronerl commented Jan 31, 2023

bors try

bors bot added a commit that referenced this pull request Jan 31, 2023
@bors
Copy link

bors bot commented Jan 31, 2023

try

Timed out.

Copy link
Contributor

@gronerl gronerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Regarding the testing of defir_to_gtir: If it is too much effort, I won't block because of this. After all, it is also not tested in the current form.

src/gt4py/cartesian/gtscript.py Outdated Show resolved Hide resolved
src/gt4py/cartesian/frontend/defir_to_gtir.py Outdated Show resolved Hide resolved
@gronerl
Copy link
Contributor

gronerl commented Feb 1, 2023

bors try

bors bot added a commit that referenced this pull request Feb 1, 2023
@bors
Copy link

bors bot commented Feb 1, 2023

try

Build succeeded:

@gronerl
Copy link
Contributor

gronerl commented Feb 1, 2023

Ready to merge once CAA is cleared.

@FlorianDeconinck
Copy link
Contributor Author

Cheers @gronerl!

Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! Let's add your new affiliation to the authors list.

@gronerl
Copy link
Contributor

gronerl commented Feb 7, 2023

@gronerl
Copy link
Contributor

gronerl commented Feb 7, 2023

We were asked to hold back with merging until #1150 is merged. We will still get this in for the next version tag.

@havogt
Copy link
Contributor

havogt commented Feb 8, 2023

bors try

bors bot added a commit that referenced this pull request Feb 8, 2023
@havogt havogt merged commit 4be34ec into GridTools:main Feb 8, 2023
@bors
Copy link

bors bot commented Feb 8, 2023

try

Timed out.

1 similar comment
@bors
Copy link

bors bot commented Feb 9, 2023

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants