-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/literal parametrized dtype #1139
Feature/literal parametrized dtype #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking the merge, until we have a new CAA.
bors try |
tryTimed out. |
bors try |
tryTimed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Regarding the testing of defir_to_gtir: If it is too much effort, I won't block because of this. After all, it is also not tested in the current form.
…_make_literal. Revert param position switch.
tests/cartesian_tests/unit_tests/test_gtc_backend/test_defir_to_gtir.py
Outdated
Show resolved
Hide resolved
bors try |
tryBuild succeeded: |
Ready to merge once CAA is cleared. |
Cheers @gronerl! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience! Let's add your new affiliation to the authors list.
@FlorianDeconinck can you add your name to https://github.com/FlorianDeconinck/gt4py/blame/feature/literal_parametrized_dtype/AUTHORS.rst as appropriate? |
We were asked to hold back with merging until #1150 is merged. We will still get this in for the next version tag. |
bors try |
tryTimed out. |
1 similar comment
tryTimed out. |
Description
In order to run a 32-bit float version of the model, we need at minima to be able to control literal dtype. This PR implements option 4 of the gtscript concept workshop
Requirements
Before submitting this PR, please make sure:
Additionally, if this PR contains code authored by new contributors:
signed by the employer if needed, provided to ETH Zurich