feat[next][dace]: GTIR-to-SDFG lowering of shifts #1577

edopao · 2024-07-12T14:02:20Z

This PR adds support for lowering of the shift operator to DaCe SDFG. It supports both cartesian and unstructured shift. The shift also works with dynamic offset. The lowering is designed in a way to support pure fieldview IR as well as mixed IR with composition of shift operators.

Additional changes:

type inference is enabled
the IR maker as_fieldop is imported from gtir branch and the IRs in dace tests are updated to use it
the storage for literal values and symbols is changed to scalar (was array before)
removed extra call around the cond primitive, which was not needed since no arguments are passed

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_tasklet.py

philip-paul-mueller

I only looked at the SDFG parts.
There is nothing really major.

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_tasklet.py

egparedes

Just minor comments and a couple of questions.

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_tasklet.py

…ction)

edopao · 2024-07-24T09:14:16Z

@tehrengruber I have imported some helpers from gtir branch in src/gt4py/next/iterator, and I have added type inference for the cond builtin. Maybe you could have a look at it.

tests/next_tests/unit_tests/iterator_tests/test_type_inference.py

src/gt4py/next/iterator/type_system/type_synthesizer.py

philip-paul-mueller

Just some questions and a proposal for clarification of wording.

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_tasklet.py

edopao added 30 commits April 18, 2024 11:36

Skeleton for ITIR translation

b36fcb3

Minor edit

2020182

Use Python callstack as a context stack for the ITIR visitor

5c6b6ba

Format error

60e1c69

Refactor tasklet codegen

073a0a4

Code refactoring

50be68f

Add domain to field operator

4e2dc15

Minor edit

ea9da35

Remove hard-coded field shape

daf7827

Remove hard-coded target domain

9672b3b

Merge remote-tracking branch 'origin/main' into dace-fieldview

b6326b8

Refactoring

26f3790

Merge remote-tracking branch 'origin/main' into dace-fieldview

1efffa7

Fix formatting

f99fa84

More refactoring

d6e1088

Minor edit

9854497

Fix formatting

37d83d7

Use callable to build taskgraph

29986ef

Add draft of select operator

390f3b4

Remove node mapping

de27419

Remove node mapping (fix + test case)

cd900f5

Add test case for inlined mathematic builtins

326cbb5

Go full functional (remove SDFGState member var)

a10b614

Minor edit

aef4265

Minor edit (1)

9e67dfe

Fix state handling

4b4109e

Edit comments based on review

495fd0a

Add test case for nested select

0085194

Separate builtin translation from driver logic

41e2a44

Improve code comments

7148c5f

edopao added 3 commits July 12, 2024 15:44

Merge remote-tracking branch 'origin/main' into dace-fieldview-shifts

a6b191c

Merge remote-tracking branch 'origin/main' into dace-fieldview-shifts

3b42f21

Edit code comments

a6adb8f

edopao marked this pull request as ready for review July 22, 2024 09:41

edopao requested a review from egparedes July 22, 2024 09:41

edopao commented Jul 22, 2024

View reviewed changes

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_tasklet.py Outdated Show resolved Hide resolved

edopao added 2 commits July 22, 2024 15:50

Fix typo

22c0d6e

Merge remote-tracking branch 'origin/main' into dace-fieldview-shifts

25fdf06

philip-paul-mueller reviewed Jul 23, 2024

View reviewed changes

edopao added 2 commits July 23, 2024 14:55

Integrate type system into dace backend

c627c31

Review comments

823f227

egparedes reviewed Jul 23, 2024

View reviewed changes

edopao added 5 commits July 24, 2024 10:03

Review comments

46012a3

Add test coverage for cond type inference

efa79cd

Merge branch 'main' into dace-fieldview-shifts

24e0f04

Add IR maker for as_fieldop (imported from gtir branch)

775fe9c

Update tests that were using cond as argument name (now a builtin fun…

cece1b1

…ction)

edopao requested review from egparedes and philip-paul-mueller July 24, 2024 09:14

Minor edit

43283cc

tehrengruber reviewed Jul 24, 2024

View reviewed changes

tests/next_tests/unit_tests/iterator_tests/test_type_inference.py Outdated Show resolved Hide resolved

src/gt4py/next/iterator/type_system/type_synthesizer.py Outdated Show resolved Hide resolved

edopao added 2 commits July 24, 2024 15:11

Use scalar storage (not array) for symbols and literals

f0a7776

Remove FunCall wrapper to cond primitive

84f15d5

edopao requested a review from tehrengruber July 24, 2024 14:34

tehrengruber approved these changes Jul 25, 2024

View reviewed changes

philip-paul-mueller reviewed Jul 25, 2024

View reviewed changes

Review comments

c1ff003

edopao merged commit 1051a6d into GridTools:main Jul 25, 2024
31 checks passed

edopao deleted the dace-fieldview-shifts branch July 25, 2024 09:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat[next][dace]: GTIR-to-SDFG lowering of shifts #1577

feat[next][dace]: GTIR-to-SDFG lowering of shifts #1577

edopao commented Jul 12, 2024 •

edited

Loading

philip-paul-mueller left a comment

egparedes left a comment

edopao commented Jul 24, 2024

philip-paul-mueller left a comment

feat[next][dace]: GTIR-to-SDFG lowering of shifts #1577

feat[next][dace]: GTIR-to-SDFG lowering of shifts #1577

Conversation

edopao commented Jul 12, 2024 • edited Loading

philip-paul-mueller left a comment

Choose a reason for hiding this comment

egparedes left a comment

Choose a reason for hiding this comment

edopao commented Jul 24, 2024

philip-paul-mueller left a comment

Choose a reason for hiding this comment

edopao commented Jul 12, 2024 •

edited

Loading