Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Java Args for Scripts #73

Closed
kreezxil opened this issue Aug 24, 2021 · 6 comments
Closed

Custom Java Args for Scripts #73

kreezxil opened this issue Aug 24, 2021 · 6 comments
Assignees
Labels
enhancement New feature, request or improvement

Comments

@kreezxil
Copy link

Have an option to input custom java args for the servers.

@Griefed
Copy link
Owner

Griefed commented Aug 25, 2021

For future issues / bug reports, please use the templates. They exist for a reason. 🙂

@Griefed Griefed self-assigned this Aug 25, 2021
@Griefed Griefed added the enhancement New feature, request or improvement label Aug 25, 2021
@kreezxil
Copy link
Author

kreezxil commented Aug 25, 2021 via email

@Griefed
Copy link
Owner

Griefed commented Aug 25, 2021

  • By having the text at places I expect them to be at all times, which helps me quickly identify the important bits for me.
  • By forcing the issue opener to explain in as much detail as possible what they want, by describing the way the app currently works and how they would like it to work.

@Griefed
Copy link
Owner

Griefed commented Aug 27, 2021

Will be available in the next alpha release and configurable through a separate dialog. Said dialog will be available in the menu bar -> Edit -> Edit Start-Scripts Java Args

Configuration for the Java arguments with which to generate start scripts will not be part of the tab which allows the configuration of everything else regarding server packs as they are not a vital, or mandatory part rather, of a server pack.

Specified arguments will be saved to the serverpackcreator.conf-file. If a given config-file does not contain a setting for said arguments, it will be automatically added, thus no migration-effort is needed on the end-users part.

This replaces the copying which ServerPackCreator currently does if the user checked `Include start-scripts" and will instead generate the start scripts with the configuration for Java arguments provided in the config/GUI.

@Griefed Griefed closed this as completed Aug 27, 2021
@Griefed
Copy link
Owner

Griefed commented Aug 27, 2021

See Alpha-Release 3.0.0-alpha.1

@kreezxil
Copy link
Author

kreezxil commented Aug 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request or improvement
Projects
None yet
Development

No branches or pull requests

2 participants