Make Poll create close, change init and make tally #9
Conversation
There was a problem hiding this comment.
options @ 47 won't take all options currently, needs *, before the variable declaration
rename create to start and close to end
Other than that it looks good to me, but probably should let @architdate and/or @noirscape take a glance at it too before merging
…an since invoke stays, add pollinfo, formatting for tally
There was a problem hiding this comment.
Left quite a couple of suggestions.
d.py is a powerful framework but uh... a lot of this code really doesn't take advantage of that.
- You're doing error handling for missing arguments in the command itself, there's a dedicated way to do this.
- Group the Poll command.
- Filenames use + for combining strings in a couple places. This is bad form and inconsistent with the earlier use of f-strings to make a string.
- There's a couple of spacing issues in some function calls (no spaces after a comma). I've highlighted a single example.
- is_poll_ongoing() sends text if it fails. Bad form, this should be done through an error handler.
- Tally command doesn't properly wait for the Queue to be empty, use the asyncio.Queue.join() function.
|
Whups forgot to remove that when I'd removed it sending what was inputted, since I realized that wasn't necessary cause no command deletion. |
Uses join() and task_done()
- Poll info during poll is in `poll.json` while votes are in `votename_votes.json` - Poll info after vote is all moved to `Polls` folder with `poll.json` becoming `votename.json` - No longer writing empty dicts to files, just remove the damn thing. - Explicit str casting to prevent double votes - Swap out all `cmd` functions to their actual yknow, names? - Added spacing -> Compacted code might look good in low LOC, but it doesnt make it more readable. - Moved poll_ongoing boolean set to before moving the files, that prevents voters during the file move. - Poll tallies before closing.
architdate
requested review from
architdate
and removed request for
architdate
Fixes #6 Fixes #5 Fixes #4 Fixes #2
Note: For any further changes to this branch, please make sure you do not accidentally merge json files, as the gitignore has not been updated on this branch