Added UI features #14
Conversation
Imagehandler.py
Outdated
| @@ -7,6 +7,7 @@ | |||
| from PatternFinding import PatternFinding | |||
| from FindingOrientationOfContours import FindingOrientationOfContours | |||
| from AffineTransformation import AffineTransformation | |||
| import numpy as np | |||
There was a problem hiding this comment.
are we using this module in this file?
There was a problem hiding this comment.
In case of debugging, line no - 70 uses numpy. But we are not using numpy.
Imagehandler.py
Outdated
| @@ -48,36 +49,38 @@ def WritingImage(self, image, path, imageName): | |||
| cv.imwrite(path + imageName, image) | |||
| cv.imshow(imageName, image) | |||
| cv.waitKey(0) | |||
| cv.destroyAllWindows() | |||
There was a problem hiding this comment.
If we are not using this(line no 52), then the program crashed after showing the output image.
Imagehandler.py
Outdated
| # cv.waitKey(0) | ||
| #uncomment this to see the contours on the image | ||
| #cv.drawContours(thresholdImage, contours, -1, (255,255,0), 3) | ||
| '''#patternFindingObj=PatternFinding() |
There was a problem hiding this comment.
I am sorry, I was not aware of that change.
Imagehandler.py
Outdated
| contour_group = (thresholdImage, contours, hierarchy) | ||
| return contour_group | ||
|
|
||
| def QRCodeInImage(self): | ||
| patternFindingObj = PatternFinding( | ||
| self.GetImageContour(), self.imageOriginal) | ||
| patterns = patternFindingObj.FindingQRPatterns(3) | ||
| if len(patterns): | ||
| if len(patterns) == 0: | ||
| print 'patterns unble to find' |
There was a problem hiding this comment.
I didn't understand. Can you elaborate this?
PatternFinding.py
Outdated
| cv.imshow('hello', self.image) | ||
| #cv.imshow('best qr contour', self.image) #uncomment to debug | ||
| #cv.waitKey(0) | ||
| #cv.destroyAllWindows() |
There was a problem hiding this comment.
I didn't get it.
There was a problem hiding this comment.
cv. destroyAllWinddows doesn't seem to be properly indented
PatternFinding.py
Outdated
| QRPatterns.append(patterns[ind]) | ||
| #cv.destroyAllWindows() |
There was a problem hiding this comment.
I think all indentations are correct. Did you encounter any error?
config.yml
Outdated
| @@ -4,8 +4,8 @@ | |||
|
|
|||
| #@author: Ankit Singh | |||
| Main: | |||
| Input : 'C:\Users\310247467\Desktop\learn\qr\Input\' | |||
| Output: 'C:\Users\310247467\Desktop\learn\qr\Results\' | |||
| Input : '/home/ujjaldas223/projects/QRCodeReader/Input/' | |||
There was a problem hiding this comment.
Any specific need to change this?
|
I am really sorry. I didn't reviewed the code and opened a pull request. Now I have updated them. |
|
@Griffintaur It seems like you want me to include |
|
fixes #14 |
I have modified some codes, so that at run time, the program would not crash and written simple UI that run in browser having an additional dependency "flask". Feel free to discuss with me about these.