Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use recipes data from groceristar-fetch #59

Closed
1 task done
atherdon opened this issue Jul 4, 2018 · 14 comments
Closed
1 task done

use recipes data from groceristar-fetch #59

atherdon opened this issue Jul 4, 2018 · 14 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atherdon
Copy link
Member

atherdon commented Jul 4, 2018

  • install our package by npm install @groceristar/groceristar-fetch

We cannot move forward, while we didn't have static data, related to recipes in our module

@atherdon atherdon added wontfix This will not be worked on not finished labels Jul 4, 2018
@atherdon atherdon self-assigned this Jul 4, 2018
@atherdon atherdon changed the title use recipes data from groceristar-fetch (Blocker) use recipes data from groceristar-fetch Jul 13, 2018
@sanchit94
Copy link
Collaborator

I think this one is done partially now!

@atherdon
Copy link
Member Author

Nah, you just find a data from search-form/search-api.
This tasks is related to data that we need: GroceriStar/groceristar-fetch#26
GroceriStar/groceristar-fetch#2 and we didn't started them yet @sanchit94

@atherdon
Copy link
Member Author

i got a PR from guy that working on fetch plugin, and when i'll publish the newest version of this plugin - we'll be able to get that data from our plugin

@atherdon
Copy link
Member Author

@atherdon atherdon changed the title (Blocker) use recipes data from groceristar-fetch use recipes data from groceristar-fetch Jul 23, 2018
@atherdon
Copy link
Member Author

@sanchit94 i add some code to your repo. i think now you can use data from groceristar-fetch plugin and display in on your project

@atherdon atherdon added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed not finished wontfix This will not be worked on labels Jul 29, 2018
@sanchit94
Copy link
Collaborator

sanchit94 commented Jul 29, 2018 via email

@atherdon
Copy link
Member Author

it's ok, not a problem. i was just reviewing the issues for different repos and update some of them

@sanchit94
Copy link
Collaborator

Hey @atherdon I was just looking at the code you added, the RecipeTest component. So what will we be doing with this data? Do you want to me to create a component(card) where this data will be displayed?

@sanchit94
Copy link
Collaborator

Also I was wondering, when would we use http requests. I mean when I add a meal using the addMealModal, I should be sending a request to the server with this data. I think this will be a good added function to our repo! Please advice! :)

@atherdon
Copy link
Member Author

yeah. i was thinking about it too.
the main trouble - 2 of our servers are working weird right now.

i assume third(server with recipes) still working fine. but as we decided to move to graphQL - i think it'll better to connect to database by using graphQL approach.
tell me - did you finish that graphQL course? if yes - we can start to build a graphQL schemas, and then we'll be able to send requests from your form to graphQL instance

@sanchit94
Copy link
Collaborator

Yes I finished that course(almost). :p

@sanchit94
Copy link
Collaborator

Let's start a task in this direction. Maybe we'll make slow progress but that's better than no progress.

@atherdon
Copy link
Member Author

atherdon commented Jul 31, 2018 via email

@sanchit94
Copy link
Collaborator

Yea I think it is pretty cool, would get a better perspective regarding it when I actually work on it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants