Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added E Commerce website #6

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Conversation

rahulch-1
Copy link
Contributor

This is an E-Commerce Website made using HTML, CSS, JavaScript which has products with their description and their reviews.

@iamwatchdogs
Copy link
Contributor

@rahulch-1 Please make the required changes to pass the lining checks, so that we can review and merge your PR. And don't worry about the files that end with **.min.js as the eslinter configs have been updated to ignore those files.

Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes, so that we can perform another code review to approve your PR to merge.

E-commerce website/.github/ISSUE_TEMPLATE/bug.yaml Outdated Show resolved Hide resolved
E-commerce website/css/.DS_Store Outdated Show resolved Hide resolved
E-commerce website/js/.DS_Store Outdated Show resolved Hide resolved
E-commerce website/js/about.js Outdated Show resolved Hide resolved
E-commerce website/js/revolution/.DS_Store Outdated Show resolved Hide resolved
E-commerce website/js/revolution/js/.DS_Store Outdated Show resolved Hide resolved
@iamwatchdogs iamwatchdogs added the hacktoberfest Opted for hacktoberfest label Oct 25, 2023
@iamwatchdogs
Copy link
Contributor

@rahulch-1 don't worry about the lining checks for now, as the only issues that are reported for creating unused variables (which were used in other files) and not recognising the jquery syntax.

@iamwatchdogs iamwatchdogs removed their assignment Oct 29, 2023
Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulch-1 The only changes that were made to resolve the code review issue is to remove a single .DS_Store file from your projects. You still need to make the following changes:

  • Remove the directory/file names .github.
  • Remove all .DS_Store files.
  • Reply to the previously mentioned comments about openhand.html and close hand.html (You can find them in our PR conversation)

Note

Don't worry about the linting checks as we're ignoring them for your case. Just make the above mentioned changes.

@rahulch-1
Copy link
Contributor Author

Now I removed the .github directory and all the .DS_Store files also

@rahulch-1
Copy link
Contributor Author

Thanks for helping me out

@iamwatchdogs
Copy link
Contributor

@rahulch-1 you have indeed removed .github directory but you haven't removed all .DS_Store file.

@iamwatchdogs
Copy link
Contributor

iamwatchdogs commented Oct 29, 2023

All of these remaining .DS_Store file paths are mentioned in previous code reviews that are present within this conversation.

@rahulch-1
Copy link
Contributor Author

Sorry, but I am not able to find any .DS_store files now

@iamwatchdogs
Copy link
Contributor

Thanks for helping me out

It's okay @rahulch-1. Just so you know, this linter makes sure each and every file maintains its integrity and works as intended without any syntactical errors. In some cases, the linter that we have used checks purely for JavaScript and doesn't recognise any external framework. This is the reason why people set up linter within their projects that are built using frameworks, as these linter will be configured according to the framework avoiding any linting issues. And the way we configured our linter for this repo is for pure javascript files and not medium to big projects built using frameworks like React.

We respect your patience and willing to contribute, but I, @iamwatchdogs, as the main maintainer have to make sure you give the best from your side while maintaining the whole integrity of the repo. So, please have some patience as when we request to make a few changes. Hope this helps you understand what we at @Grow-with-Open-Source are trying to do.

@iamwatchdogs
Copy link
Contributor

Sorry, but I am not able to find any .DS_store files now

Sorry for that @rahulch-1, Yes all the files were removed.

Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request Changes were made. Reviewed and Approved by @iamwatchdogs.

@iamwatchdogs iamwatchdogs merged commit d245e0d into Grow-with-Open-Source:main Oct 29, 2023
@iamwatchdogs iamwatchdogs added the hacktoberfest-accepted Successfully accepted pull request for hacktoberfest label Oct 29, 2023
@rahulch-1
Copy link
Contributor Author

yes, @iamwatchdogs I completely understand the need for a specialized linter setup

@iamwatchdogs
Copy link
Contributor

Thank you for contributing, @rahulch-1. Please check your contribution on GitHub Pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Opted for hacktoberfest hacktoberfest-accepted Successfully accepted pull request for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants