This repository has been archived by the owner on May 18, 2024. It is now read-only.
fix(ui-toolkit): RadioButtonGroup Props Handling #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for `parentClassName`, `size`, `labelClassName` - remove `restProps` which will be empty - update RadioButton component to accept `labelClassName` prop - adjust stories to demonstrate the use of additional props
rajvarsani-groww
requested review from
nitin-k-groww,
ishitasinha18,
vyapak154,
akshaybarya195,
ankitj-groww and
a team
packages/ui-toolkit/src/components/molecules/RadioButtonGroup/RadioButtonGroup.tsx
Show resolved
Hide resolved
prashant-adhikari-groww
approved these changes
Mar 28, 2024
AkshayNaikGroww
suggested changes
Mar 28, 2024
packages/ui-toolkit/src/components/atoms/RadioButton/RadioButton.tsx
Outdated
Show resolved
Hide resolved
AkshayNaikGroww
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
parentClassName,size,labelClassNamerestPropslabelClassNamepropWhat packages have been affected by this PR?
ui-toolkitTypes of changes
Package version increase in any of the packages?
Checklist before merging