This repository has been archived by the owner on May 18, 2024. It is now read-only.
fix dayjs issue #76
Merged
fix dayjs issue #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaVandan
approved these changes
Jun 8, 2022
AdityaVandan
approved these changes
Jun 8, 2022
| @@ -443,7 +443,8 @@ export function getISTDateTime(timeOffset = 0) { | |||
| const systemTime = new Date(); | |||
| const currentTime = new Date(systemTime.getTime() + timeOffset); | |||
|
|
|||
| const ISTVal = dayjs.tz(currentTime, 'Asia/Kolkata'); | |||
| // using any for now, github issue link: https://github.com/iamkun/dayjs/issues/1617 | |||
| const ISTVal = (dayjs as any).tz(currentTime, 'Asia/Kolkata'); | |||
There was a problem hiding this comment.
refrain from using any, but I see the issue, can work on it later
AdityaVandan
requested review from
ankitchouhan1020,
ristri and
StTronn
and removed request for
ankitchouhan1020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue related to dayjs types
What packages have been affected by this PR?
ella
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyBugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Package version increase in any of the packages?
0.1.8
Checklist before merging
Put an
xin the boxes that applyThese changes have been thoroughly tested.
Changes need to be immediately published on npm.