Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sent but not implemented #53

Closed
jbrichau opened this issue Sep 14, 2014 · 6 comments
Closed

Sent but not implemented #53

jbrichau opened this issue Sep 14, 2014 · 6 comments

Comments

@jbrichau
Copy link
Member

See GsDevKit/Seaside31#44:

'Sent but not implemented: #''addDeferredStartupAction:'''
'Sent but not implemented: #''getPng:'''
'Sent but not implemented: #''getGif:'''

@jbrichau
Copy link
Member Author

It seems the ZnEasy class is missing the getPng and getGif methods. I'm guessing these were left out of the port because of the absence of ImageReadWriter in Gemstone?

#addDeferredStartupAction: is sent by ZnServer>>startUp and can be safely removed.

@dalehenrich
Copy link
Member

On Sun, Sep 14, 2014 at 11:12 AM, Johan Brichau notifications@github.com
wrote:

It seems the ZnEasy class is missing the getPng and getGif methods. I'm
guessing these were left out of the port because of the absence of
ImageReadWriter in Gemstone?

That's be a good guess ...

#addDeferredStartupAction: is sent by ZnServer>>startUp and can be safely
removed.

Sounds right ...

I will be adding Zinc to the GsUpgrader test suite today ... GsUpgrader is
turning into the project where I'm doing the full system testing ... we may
want to kick off a GsUpgrader travis run before doing a release for
zinc/Seaside/GLASS/etc. .....

@dalehenrich
Copy link
Member

add #bench to list:

'Sent but not implemented: #''bench'''

#bench shows up when zinc tests are loaded and run ... zinc tests probably loaded as part of Seaside31

@dalehenrich
Copy link
Member

For 2.4.5.2, the OverriddenBaseMethodsTest>>#testOverriddenBaseMethods test fails.

The implication is that there is an existing base method being overridden and/or different from the standard override ... OverriddenBaseMethodsTest>>#testOverriddenBaseMethods is in the base GLASS tests and nor normally tested in Zinc itself ...

dalehenrich added a commit to GsDevKit/gsUpgrader that referenced this issue Sep 15, 2014
…versions in line-up ... see if 2.4.4.1 and 2.4.4.7 will pass TEST_GLASS1
@dalehenrich
Copy link
Member

re-enable the zinc and seaside tests in GsUpgrader when this bug is fixed

dalehenrich added a commit to GsDevKit/gsUpgrader that referenced this issue Sep 15, 2014
dalehenrich added a commit that referenced this issue Nov 18, 2014
… should be fixed .... of course Issue #61 and Issue #62 were opened to implement the missing behavior
@dalehenrich
Copy link
Member

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants