Added in /upload route for a simplistic API #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| urls.append(v) | ||
| res = "{" | ||
| for url, f in zip(urls, files): | ||
| res += f + ":" + url + "," |
There was a problem hiding this comment.
Wouldn't it be a better idea to make a list of dictionaries and serialize it to JSON? This way it wouldn't even work since f and url won't be received as strings.
Guad
added a commit
that referenced
this pull request
Jun 20, 2015
Added in /upload route for a simplistic API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple doc should be written to describe the API which essentially returns a JSON in the format {original file name:fuwa.se url/response}
Also, can the repo be renamed to Fuwa?