-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Сustom commands - does not work #1243
Comments
fixed on HEAD |
Hello! Today I installed, finally, a new version of Guake v3.2, but bug with non-working custom-commands so remained.
|
Oh, what version of the vte component do you have ? Look like you use the old api |
I used your command file and it worked, does it fails on every command on only one particular? |
Same issue here, also on Arch. Vte is |
I have, now established version of vte3 0.52.1-1 (Last Updated in Arch-repository: | 2018-04-09 20:28 UTC). But I tried to install and: vte3-git 0.39.91 and vte-legacy 0.28.2-10 (for use with GTK2). The custom commands does not work on any of these versions of vte.
|
Vte is really a mess to deal with. They break the api every few version and does not follow semver (Gtk being even worst). |
On actual Manjaro/ArchLinux is possible to invoke this problem even easier - for example run Workaround: downgrade vte3 package (for me works previous version 0.51.3-0.1). |
works for me :( |
Sorry guys, I have added a new change on HEAD, but I think it will fail on your version of VTE. Can one of you try to fix the line in Between the version of VTE and the adaptation layer PyVTE that does some magic, I am lost, and I still not have a way to test on VTE >=0.50 (I am on VTE 0.42 on Ubuntu). Also, these So for this, can one of you checkout the code, use |
So, I finally got a fedora 26 with vte 0.52 working, the HEAD works great. |
Hello! I tried on your advice to change the call
I feel sorry. |
The problem is really in version vte. I have now installed the version 0.50.2.a-1 (vte3-ng-fullwidth-emoji) from the AUR repository and... tadaaaam! - custom commands are working!!! Hurray! I'm thrilled. Gsemet, thank you for the tips and your participation! |
Can you summarize your issue so that I can add it in a “known issue” on the
release note and the FAQ? so that other can benefit from your finding :)
Thanks
Le jeu. 19 avr. 2018 à 07:09, igorog <notifications@github.com> a écrit :
The problem is really in version *vte*. I have now installed the version
*0.50.2.a-1* (vte3-ng-fullwidth-emoji) from the AUR repository and...
tadaaaam! - custom commands are working!!! Hurray! I'm thrilled. Gsemet,
thank you for the tips and your participation!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1243 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIJeq30lo1Wx9FjrZPj0Cjkm7ILw84Xks5tqBwcgaJpZM4TNk7q>
.
--
-----
Gaetan
|
Gaetan! As I already wrote in the previous post - fixing the health of custom commands by "manual" lowering the VTE version - this is, as it turns out, a bad practice in Arch Linux. In connection with the "manual" lowering of the proposed packages (specifically VTE) - newly installed packages will have to manually register different system dependencies, and it is "crooked and not aesthetically pleasing" : ). Therefore, it is not applicable to the General public. It is necessary to look still normal decision with respect to VTE version >= 0.52, unfortunately. ((( Igor |
Do you have an iso I can arch linux easily from (boot directly in GNOME with VTE, ...)? I don't know this system and how to install it on Parallel? PS: on fedora, 0.52 works :( |
@gsemet Try Manjaro GNOME edition ... it's actual Arch Linux with GNOME customization. Download on https://manjaro.org/get-manjaro/ as ISO image, boot it and use it in Live Distro mode (without installation). |
My little investigation: |
By the way, yes, probably, a good option |
if you find the right python call I can encapsulate on try except to that it can work no matter the system... will try to install manjaro this evening :) |
GIR file looks like XML annotation for GObject API - I diffed it and the only differences are data type of parameter text - first one is string, second is one field array with string inside. OLD GIR (working)
NEW GIR (not working)
DIFF
PS: Attention - Manjaro is addictive :-) |
I have install vte3-ng-fullwidth-emoji - it's works for me at Manjaro Gnome. |
So I got manjaro on my parallels. Parallels tools does not install yet but I think I'll be able to start working on this asap :) If anyone of you is motivated enough to work on stabilizeing Guake on Arch, that would still help me a lot ! |
I'm ready, than I will be able to help you. 😄 |
I'm on arch and Custom-Commands are working fine for me. Commands file:
|
"If something doesn't work for you, you just don't know how to cook it." 😃 Teach how to cook Arch properly to work. Your file doesn't work for me as well as mine.
|
So yesterday I tested arch and on manjaro the quickopen and url links did not work indeed. Not tested custom commands |
@igorog What I was trying to say was that this is not a problem with guake's code but rather with some packages. Are you on "real" arch or a derivation like manjaro or antergos (at least for antergos I can tell that they patch some packages)? Teaching how to cook arch: Run |
I'm on the "purest" Arch. 😄
And such "dishes" I have learned to cook. Not helping. 😄 |
If you find limitation on Arch, please add in the doc (FAQ or arch specific section) ! Thanks for the help guys ! |
Thank you, Gaetan! You beat this bug! I have now compiled a new version of 3.2.1 (because it does not exist in the arch repository) and everything works. |
Ive been silently following this thread as I have the same problem, but not anymore. |
It is what I call a team work :) |
Im having this issue on ubuntu 18 -
any time I run a command with guake -e |
please update using pip: pip install --user guake |
For Guake I have the same problem: Info:
Traceback:
@gsemet,
|
I don’t do packaging. I see guake not being updated in fedora and debian and that annoys me a lot :( arch is pretty much up to date. Please ensure to remove everything in /usr/local/lib/python3.6/dist-package/guake and use pip install —user |
Thanks, fixed by run this command as not root: |
Here's the story. VTE's C api did not change, but its Python bindings indeed did. The intended, correct, and as of vte-0.52 finally achieved version is where there is no separate parameter for the length, that is, only 2 arguments are passed to the method. The "(array length=length)" annotation is responsible for this correct binding. The The The Now comes the twist. Ubuntu breaks it. (Xenial is still okay, Y-Z-A are beyond EOL, so I only care about Bionic LTS and future releases.) In the original Bionic release they had a faulty change (silently squeezed into their big PCRE2 patch) that erroneously removed the required annotation from all three of these methods, requiring them to take 3 parameters. In a subsequently released fix they removed this broken patch, "fixing" VTE (making it behave as upstream), but this on the other hand broke some apps that relied on the broken behavior. Therefore, in turn, they are about to reintroduce this patch for Bionic, see Launchpad 1780501. As far as I understand, and I do sincerely hope, they only do this back and forth in Bionic; in Cosmic they'll hopefully settle with the correct mainstream solution and fix all the apps that relied on the faulty behavior. What can you do for now?
I'm sorry for any inconvenience this story caused. |
Thanks for your comment ! help understanding. If try/except does the job, let's stick with this brutal-yet-effective approach |
Only after submitting my comment did I realize that you have already implemented try/except. Sure, probably the most reasonable solution in this mess! |
1. [template] Added additional dependencies against build warnings 2. [patch] Updated for latest meson 3. [patch] Updated for latest python module name (instead of deprecated `python3` module, changed to `python` module, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types ) 4. [patch] Fixed breakage of write functionality due to recent changes in Vte python bindings. Used to raise a `TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)` error which has been fixed. (Explanation here: Guake/guake#1243 (comment) )
1. [template] Added additional dependencies against build warnings 2. [patch] Updated for latest meson 3. [patch] Updated for latest python module name (instead of deprecated `python3` module, changed to `python` module, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types ) 4. [patch] Fixed breakage of write functionality due to recent changes in Vte python bindings. Used to raise a `TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)` error which has been fixed. (Explanation here: Guake/guake#1243 (comment) )
Arch Linux 'any' Repository: guake 3.0.5-2 Community Maintainers: Balló György Build Date: 2018-03-27 16:51 UTC Last Updated: 2018-03-27 17:00 UTC
System: (Linux 4.15.15-1-ARCH #1 SMP PREEMPT Sat Mar 31 23:59:25 UTC 2018 x86_64 GNU/Linux)
DE: Cinnamon
Steps to reproduce: I created the file ~/.config/gconf/apps/guake/custom-command-file.json, but after selecting a command, from the context menu - nothing happens. My commands are not executed! Please check:
custom-command-file.txt
Output when click custom commands from context menu:
The text was updated successfully, but these errors were encountered: