Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to importlib_resources #1405

Closed
gsemet opened this issue Sep 17, 2018 · 4 comments
Closed

migrate to importlib_resources #1405

gsemet opened this issue Sep 17, 2018 · 4 comments

Comments

@gsemet
Copy link
Member

gsemet commented Sep 17, 2018

Replace ugly pkg_resource by importlib_resources

@gsemet gsemet added this to the -- Next Version -- milestone Sep 17, 2018
@gsemet gsemet modified the milestones: 3.5.0, -- NEXT VERSION -- Apr 3, 2019
@gsemet gsemet modified the milestones: 3.6.0, -- NEXT VERSION -- Apr 26, 2019
gsemet added a commit that referenced this issue Apr 29, 2019
gsemet added a commit that referenced this issue Apr 29, 2019
@gsemet gsemet modified the milestones: 3.6.3, -- NEXT VERSION -- May 13, 2019
@Davidy22
Copy link
Collaborator

I notice current guake repo contains neither importlib_resources nor pkg_resource. Is this still a thing we're doing, or has this been resolved on the side of unrelated other changes in the intervening time?

@gsemet
Copy link
Member Author

gsemet commented Sep 30, 2021

close it if no more relevant,

@Davidy22
Copy link
Collaborator

Since neither of the packages in question are actually used in the codebase, closing.

@eli-schwartz
Copy link
Collaborator

Per 31622cb I don't believe pkg_resources was ever used -- but it did used to be imported until recently.

Per bc14194 importlib_metadata is used, but not importlib_resources -- together, these two modules fulfill most of the utility which pkg_resources provides (because pkg_resources does many things, all of them slow, and importlib has been adopting them in a careful and selective manner via carefully scoped APIs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants