-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to importlib_resources #1405
Comments
I notice current guake repo contains neither importlib_resources nor pkg_resource. Is this still a thing we're doing, or has this been resolved on the side of unrelated other changes in the intervening time? |
close it if no more relevant, |
Since neither of the packages in question are actually used in the codebase, closing. |
Per 31622cb I don't believe pkg_resources was ever used -- but it did used to be imported until recently. Per bc14194 importlib_metadata is used, but not importlib_resources -- together, these two modules fulfill most of the utility which pkg_resources provides (because pkg_resources does many things, all of them slow, and importlib has been adopting them in a careful and selective manner via carefully scoped APIs). |
Replace ugly pkg_resource by importlib_resources
The text was updated successfully, but these errors were encountered: