Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background and font color inversed for some color schemes #516

Closed
hotice opened this issue May 4, 2015 · 6 comments
Closed

Background and font color inversed for some color schemes #516

hotice opened this issue May 4, 2015 · 6 comments

Comments

@hotice
Copy link

hotice commented May 4, 2015

(Guake 0.7.0): some of the built-in color schemes shipped with Guake 0.7.0 have inverse background and font color inversed. I can say for sure that this occurs with the Solarized (all of them) color schemes but could also be others (I'm only familiar with the Solarized colors).

Here's a screenshot with Solarized Dark with the default Guake 0.7.0 colors: http://i.imgur.com/Z2D74av.png

This is how it should look: http://i.imgur.com/1sVrrkh.png

@gsemet
Copy link
Member

gsemet commented May 4, 2015

@varemenos can you check ?

@varemenos
Copy link
Contributor

I will take a look at it once I return from work though I took a quick glimpse at the it right now and I think there was a confusion about the order of each palette's background/foreground colors, almost all the color schemes I personally know have their backgrounds and foregrounds inversed. thanks Andrei for noticing

gsemet added a commit to gsemet/guake that referenced this issue May 4, 2015
(Guake#516)

Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
@gsemet
Copy link
Member

gsemet commented May 4, 2015

Indeed, I switched the foreground and background color of each palette except the legacy ones (Tango, Linux Console, XTem, Rxvt)

@varemenos
Copy link
Contributor

can you check if you accidentally skipped inverting Zenburn's colors in the last commit?

@gsemet
Copy link
Member

gsemet commented May 4, 2015

wait...

@gsemet gsemet closed this as completed in 4cb71b5 May 4, 2015
@gsemet
Copy link
Member

gsemet commented May 4, 2015

this looks quite good now :)

gsemet added a commit that referenced this issue Jan 30, 2017
(#516)

Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
gsemet added a commit that referenced this issue Jan 30, 2017
Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
gsemet added a commit that referenced this issue Jan 30, 2017
(#516)

Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
gsemet added a commit that referenced this issue Jan 30, 2017
Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants