-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make guake use the system default theme and hide tab bar when there is only one tab #1867
Conversation
Also tied hide tab bar to some related menu options.
I should have made a seperate branch for this, but I also did a little hacking and got a thing that should resolve #924 as well. |
Yes! I was just about to propose hiding with a single tab - nice. But who knows when this will get merged... This project really needs to hand off management. |
Hiding with one tab was a resolution to an existing issue report, so someone else beat you to the punch by some amount already. I wouldn't mind taking the project up if needed, it has been a while since I made this pull request and there's a lot of other pull requests in the queue |
Hi @Davidy22, please help to change a branch from your |
We can separate this PR into two (or three), as we would like to have one purpose in one PR:
|
Alright, just gonna do some name shuffling and push some commits around. Been a while since I wrote this, but I think the cleanup was somewhat related to the themes feature |
Detect system theme by default like other gtk programs. Some misc setup/cleanup changes in the fork as well.