Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make guake use the system default theme and hide tab bar when there is only one tab #1867

Closed
wants to merge 4 commits into from

Conversation

Davidy22
Copy link
Collaborator

@Davidy22 Davidy22 commented Jul 26, 2021

Detect system theme by default like other gtk programs. Some misc setup/cleanup changes in the fork as well.

@Davidy22 Davidy22 marked this pull request as draft July 26, 2021 16:58
@Davidy22 Davidy22 marked this pull request as ready for review July 26, 2021 16:58
Also tied hide tab bar to some related menu options.
@Davidy22
Copy link
Collaborator Author

I should have made a seperate branch for this, but I also did a little hacking and got a thing that should resolve #924 as well.

@Davidy22 Davidy22 changed the title Make guake use the system default theme Make guake use the system default theme and hide tab bar when there is only one tab Jul 29, 2021
@jacksongoode
Copy link

jacksongoode commented Aug 5, 2021

Yes! I was just about to propose hiding with a single tab - nice. But who knows when this will get merged... This project really needs to hand off management.

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Aug 6, 2021

Hiding with one tab was a resolution to an existing issue report, so someone else beat you to the punch by some amount already. I wouldn't mind taking the project up if needed, it has been a while since I made this pull request and there's a lot of other pull requests in the queue

@mlouielu
Copy link
Collaborator

Hi @Davidy22, please help to change a branch from your master branch to another name, otherwise it may confuse to others.

@mlouielu mlouielu self-requested a review August 31, 2021 08:58
@Davidy22 Davidy22 deleted the branch Guake:master August 31, 2021 08:59
@Davidy22 Davidy22 closed this Aug 31, 2021
@Davidy22 Davidy22 deleted the master branch August 31, 2021 08:59
@Davidy22 Davidy22 restored the master branch August 31, 2021 08:59
@Davidy22 Davidy22 reopened this Aug 31, 2021
@mlouielu
Copy link
Collaborator

We can separate this PR into two (or three), as we would like to have one purpose in one PR:

  1. Add option to hide tab bar when we have only one tab
  2. Make Guake use system default theme
  3. Cleanup some code.

@Davidy22 Davidy22 deleted the branch Guake:master August 31, 2021 09:00
@Davidy22 Davidy22 closed this Aug 31, 2021
@Davidy22 Davidy22 deleted the master branch August 31, 2021 09:00
@Davidy22 Davidy22 restored the master branch August 31, 2021 09:00
@Davidy22
Copy link
Collaborator Author

Alright, just gonna do some name shuffling and push some commits around. Been a while since I wrote this, but I think the cleanup was somewhat related to the themes feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants