Add line height/width scale (#849) #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidy22
reviewed
Oct 12, 2021
There was a problem hiding this comment.
Works as expected, just needs a release notes file before approval. Also, there's some strange Gtk errors that happen when using sudo make install but not sudo make reinstall, I think entirely due to the glade version update. Works fine when running reinstall so ultimately not too much of an issue, but potentially needs to be noted for package maintainers in the release note file.
Also VTE 0.52's 3 years old now. Maybe some people still don't have it yet, maybe wait another year, but I do kind of want to drop the >= 0.52 note in the preferences window sometime because surely everyone who'll be updating to the newest guake will also have a newer version of VTE.
Davidy22
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add line height/width scale from Vte 0.52 (#849)
Setting path: prefs/apperance/(line height scale, line width scale)
Many thanks to @egmontkob and GNOME to adding this feature in Vte.
gnunn1/tilix#1641 (comment)