Fixing 'resizer' position in tabs-on-top mode and resizing while bottom-aligned #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks ! |
|
Somewhat related: Is there a way to disable the resize handle? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that the little resizer handle will not be at the bottom when you switch the tab-bar to the top, and also that the window will not behave correctly when resizing it while bottom-aligned. I wrote some quick fixes, although they could be better.
I still get some flickering on bottom-align resize because something tries to adjust for my taskbar... and the code to always push the resizer element to the bottom might be better of in a small helper function on its own instead of in set_tab_position.
(With a little more polish, maybe) this would fix issue #723 and 2nd/3rd point of issue #382.