Unofficial Series Code #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, it won't instantly go from stopping to stopped. I also moved the xedit regex out of the function so it doesn't compile every time the while loop polls it.
Also, redid some code for correctness and removed some redundancies.
Also moved the lower-case mapped lists to the info dataclass.
Consolidated the code to identify if a process or file name is xedit or not into a single function. It also uses mapped sets of xedit_list_universal and xedit_list_specific that apply the str.lower() method to all entries. This way, it doesn't drag other processes that have edit at the end of their file name into the mix.
This feature requires xedit >= 4.1.5b and can only be enabled through direct editing of the config file. This feature is completly use at your own risk, I can not provide support for it.
The 7z file has the correct file.
This reverts commit ad9a997.
The buttons are disabled, but to appease PyLance, I created a placeholder popup since I don't want to remove the buttons.
This should fix a bug where the journal was modified before the mtime could be checked, resulting in the journal never expiring.
This reverts commit c0fd116.
This reverts commit 8c03c88.
|
Moving the monitoring code to a separate thread seems to have fixed the "Stop Cleaning" race condition. I've only done some preliminary testing, but the results are promising. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code from my "Unofficial Series", contains all the changes from #20