Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a settings menu (offline) #45

Merged
merged 45 commits into from
Jun 11, 2020
Merged

Add a settings menu (offline) #45

merged 45 commits into from
Jun 11, 2020

Conversation

GuillaumeFavelier
Copy link
Owner

In order to provide a settings menu:

  1. rcParams should be refactored heavily to allow default values sharing
  2. params should be loaded from a JSON file or dumped to a default location
  3. A setting interface should modify and update the JSON file

Closes #15

@GuillaumeFavelier GuillaumeFavelier added enhancement New feature or request refactor Change the code but not the features labels Jun 7, 2020
@GuillaumeFavelier GuillaumeFavelier self-assigned this Jun 7, 2020
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #45 into master will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   99.10%   99.45%   +0.34%     
==========================================
  Files          13       14       +1     
  Lines         897     1100     +203     
  Branches      108      129      +21     
==========================================
+ Hits          889     1094     +205     
  Misses          3        3              
+ Partials        5        3       -2     
Impacted Files Coverage Δ
blockbuilder/app/start.py 73.33% <100.00%> (+1.90%) ⬆️
blockbuilder/block.py 100.00% <100.00%> (ø)
blockbuilder/core_plotter.py 100.00% <100.00%> (ø)
blockbuilder/element.py 100.00% <100.00%> (ø)
blockbuilder/grid.py 100.00% <100.00%> (ø)
blockbuilder/interactive_plotter.py 100.00% <100.00%> (ø)
blockbuilder/main_plotter.py 99.40% <100.00%> (+0.60%) ⬆️
blockbuilder/params.py 100.00% <100.00%> (ø)
blockbuilder/plane.py 100.00% <100.00%> (ø)
blockbuilder/selector.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1011c3a...176e50c. Read the comment docs.

@GuillaumeFavelier
Copy link
Owner Author

For now all the code of SettingDialog is on __init__, this need to be refactored and improved.

@GuillaumeFavelier
Copy link
Owner Author

GuillaumeFavelier commented Jun 10, 2020

ToDo:

  • QMessageBox for Apply and Cancel buttons
  • QColorDialog for color selection
  • Bug with the setting layout on Windows
  • Bug when importing a blockset with different dimensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Change the code but not the features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a settings menu
1 participant