Fixes for Process.name() and swap memory computation on i686-pc-windows-msvc #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name may be a full UNC path, up to 32768 characters
(old reflex for an old developer 😅)
…overflow, now using u64
GuillaumeGomez
approved these changes
Dec 30, 2023
|
Please run |
Because it works with 32 -> 32 bits (of course not for 32 -> 64 bits because of address space)
|
Tested locally and it looks all good on 64 bits. Thanks again for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targetting
i686-pc-windows, an initial try to fix #1188 which led to:– A dead-end regarding this fix (because a 32-bit process can’t read 64-bits process memory… For obvious reasons 😅)
– A fix in
Process.name()whose buffer length was too short– A fix in swap memory computation, not using
usizebut extending tou64(because even on 32-bit platforms, memory can be big 😉).