Ignore nfs on linux #876
Merged
Ignore nfs on linux #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Maybe add that NFS file systems are ignored on linux the |
GuillaumeGomez
approved these changes
Nov 23, 2022
|
Thanks! |
|
Late comment: I believe this is the correct behavior to match the other implementations for consistency too. Both macOS and Windows ignore SMB drives with their current implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the problem that calling
statvfson nfs may hang. It is done by ignoring the fs having its type namednfsornfs4.Avoiding to call
statvfson nfs will leavetotal_spaceandavailable_spaceto be zeros and can be misleading. So I decide not to include nfs in what returns fromget_all_disks_inner