This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
Add tasks to sidebar #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💄 Added tabs in sidebar (#14) :lipstick: Created tabs components: Tabs (wrapper for it all), TabsHeader (header to put tabs in), Tab (a single tab) and TabsBody (To put a tab's body in). (client/base/components/tabs.jsx :lipstick: Make body of sidebar scrollable, not the actual sidebar :art: Start assigning id of notifications from 0 instead of 1 :art: Randomize number for body for a testing notification :art: Put connection to socket.io outside the notifications component to avoid duplicate notifications when switching tabs :package: Updated links, moved babel-polyfill into dependencies and moved babel-cli into devDependencies. (package.json)
🎨 Added tabs backend functions for creating, updating, ending and cancelling tasks
💄 Added the tasks components (#14) :art: Added actions, containers and reducers for tasks (#14) :lipstick: Move header of notifications into its own component for use with tasks area :lipstick: Added tasks to tab 2's body :lipstick: Set the background of a tab to the hover colour if it is active :lipstick: Created a dummy task for checking the design :art: Added constants for tasks :lipstick: Added tasks styling :lipstick: Added animation to fade in percentage complete :art: Rebuilt the bundle :arrow_up: Installed immutable@^3.8.1 :arrow_up: Installed react-progressbar.js@^0.2.0 npm-check updates :arrow_up: Installed connect-mongo@^1.3.1 :arrow_up: Installed request@^2.74.0 :arrow_up: Installed babel-cli@^6.11.4 :arrow_up: Installed babel-core@^6.11.4 :arrow_up: Installed eslint-plugin-import@^1.11.1
🎨 Added mapping of tasks to components (#14) :art: Watch for events 'task:new' and 'task:update: on socket.io to know when to update or create a new task :art: Move back to using a normal array in the tasks reducer :art: Added title field to tasks as there was not way to specify a title :art: :ambulance: Fix a bug in app/util/schema where it testing for the type of the prop in the schema, which was always a string (even if you put 'number') :art: Added updating of tasks to constants, reducers and an action for it :lipstick: Use a div to contain sidebar items that do not link to anything :lipstick: Allow overflow-y of tasks & make tasks sidebar have height: 100% :shirt: Changed rule no-const-assign to being an error (eslint) and disabled rule PlaceHolderInExtend (scss-lint)
💄 Made notification also just a <div> 💄 Updated styles to reflect making notification a <div>
💄 Added cancellation of tasks (#14) + ability to link to other parts of bedel (through react-router or not) on click :lipstick: Updates navbar to make hamburger a non-linking item. :lipstick: Change url prop -> href prop in SidebarItem :lipstick: Added a modal to confirm whether or not you want to cancel (auto-selects 'Yes') :lipstick: Fix an issue where bootstrap theme was not being loaded in sass. :lipstick: Make body, h1, h2, h3, h4, h5, h6, p and div all Open-Sans-Light with !important as fixing theme not being loaded changed the fonts :lipstick: Fixed navbar padding + height because of fixing theme not being loaded changing the navbar :lipstick: Make sure sidebar items are never underlined link liks in all states :lipstick: Added a not-a-button mixin to remove background + border of buttons :art: Change state to status: 'Cancelling...' and percentage: 1 in tasks reducer when CANCEL_TASK is received :art: Updated defaults for tasks to add react prop (whether link is react-router or not) (default: true) + hasCancelEvent (default: false)
1 similar comment
💄 Fixed the navbar. Now whole of the navbar shows up. 💄 Rewrote navbar dropdown styles
💄 Fix sidebar hover issues 🎨 Store current tab in status reducer for sidebar 🎨 Use Object.assign() to update status 🎨 Button to open sidebar only set open to true
💄 Added accent colour + used for hamburger + tasks trail colour 💄 Show a grey message that there are no notifications/tasks. This message fades in. (#14) :lipstick: Added fadeIn css animation to fade in an object :art: Removed unused imports :arrow_up: Installed sass-variable-loader@^0.0.4 for loading accent in jsx
💄 Moved sign out onto main navbar, not a dropdown 💄 Removed padding at the end of the navbar
📦 Dependency upgrades (with npm-check): ⬆️ Installed bootstrap@^3.3.7
1 similar comment
💄 Added unread notifications counter (#14). NOTE: Should not add unread if notifications bar is open, but it does. TODO. :lipstick: Created UnreadCount component for showing a badge (client/base/components/sidebar/unread.jsx) :lipstick: Use opacity to change navbar items on hover :art: Created reducer + actions + container for counter reducer for counting unread task + notifications :art: Rebuilt the bundle. Now includes bootstrap + font awesome + hamburgers inside + fonts (loaded). :art: Removed bootstrap (css + js), font awesome (css), hamburgers (css) and socket.io-client (js) from views/index.ejs :art: Added loaders for css, fonts (using url + file loader) and svg (using file loader) :package: Ignore build/ in nodemon :arrow_up: Installed url-loader@^0.5.7
💄 🎨 🚑 Finish adding unread notifications counter by fixing a bug where counter would increment even though the sidebar was open
📖 Switch around some roadmap targets 🎨 💄 Rebuild bundle
🚑 Fix a bug with showing number of unread notifications 🎨 Rebuild bundle
🎨 Added notification storage in db 🎨 Assign ID for notifications on server side 🎨 Added webpack-dashboard 🎨 Added notifications + tasks model 🎨 Move adding to reducer to separate function 🎨 Added counter to notifications container 💄 Restyled notifications 💄 Added OpenSans-Bold to fonts list 📦 Use webpack-dashboard for nodemon ⬆️ Installed webpack-dashboard@^0.1.8
1 similar comment
🚑 Fixed an issue with ids in the database, by sending all notifications into socket.io on startup, so that the client does not have to fetch them manulally, as well as a listing issues, by using a promise to return the result of Notifications.prototype.notificationIncludesId() 🚫 Removed Tasks model, as tasks do not have to be stored, as socket.io keeps track of everything emmited
|
All items have been checked off. Merging. |
|
Merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request to add tasks to the sidebar. See issue #14 for the checklist.