Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in add_sequential_constr #312

Closed
fuadcan opened this issue Jun 12, 2024 · 2 comments
Closed

Typo in add_sequential_constr #312

fuadcan opened this issue Jun 12, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@fuadcan
Copy link

fuadcan commented Jun 12, 2024

Small thing. The package supports only torch.nn.linear and torch.nn.ReLU but the documentation says "Decision variables used as input for logistic regression". I think you meant regression.

Also, I noticed you support logistic regressions now. Do you plan to add torch model with sigmoid activation functions later?

@pobonomo pobonomo mentioned this issue Jun 13, 2024
pobonomo added a commit to pobonomo/gurobi-machinelearning that referenced this issue Jun 13, 2024
@pobonomo pobonomo self-assigned this Jun 13, 2024
@pobonomo pobonomo added the documentation Improvements or additions to documentation label Jun 13, 2024
@pobonomo
Copy link
Member

Thanks for reporting the typo. I'll fix it with #313

Regarding logistic regression, we support scikit-learn's logistic regression with two classes currently.

Supporting neural networks with sigmoid activation is something we are thinking about but didn't do so far (adding the model is not very difficult but we will have to see how hard it is to solve then).

@pobonomo
Copy link
Member

It should be fixed now https://gurobi-machinelearning.readthedocs.io/en/stable/auto_generated/gurobi_ml.torch.sequential.add_sequential_constr.html#gurobi_ml.torch.sequential.add_sequential_constr

For the sigmoid, it is something we are considering. As Gurobi is adding better and better support for nonlinear functions, we will wait a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants