Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(downloader): qdt_plugins_to_copy was not created in force mode #551

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Sep 4, 2024

When force: true in plugins downloader job, it was failing because of unbound locale var:

2024-09-04 10:03:43||ERROR||bouncer||exit_cli_error||43||cannot access local variable 'qdt_plugins_to_copy' where it 
is not associated with a value
Traceback (most recent call last):
  File "qgis_deployment_toolbelt\commands\deployment.py", line 207, in run
  File "qgis_deployment_toolbelt\jobs\job_plugins_downloader.py", line 120, in run
UnboundLocalError: cannot access local variable 'qdt_plugins_to_copy' where it is not associated with a value

@Guts Guts self-assigned this Sep 4, 2024
@Guts Guts added this to the 0.35.2 milestone Sep 4, 2024
@github-actions github-actions bot added bug Something isn't working jobs Scenarios and jobs labels Sep 4, 2024
Copy link

sonarcloud bot commented Sep 4, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (58ba890) to head (6724399).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...deployment_toolbelt/jobs/job_plugins_downloader.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   70.55%   70.52%   -0.03%     
==========================================
  Files          47       47              
  Lines        3124     3125       +1     
  Branches      669      669              
==========================================
  Hits         2204     2204              
- Misses        726      727       +1     
  Partials      194      194              
Flag Coverage Δ
unittests 69.95% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...deployment_toolbelt/jobs/job_plugins_downloader.py 50.37% <0.00%> (-0.39%) ⬇️

@Guts Guts enabled auto-merge September 4, 2024 09:22
@Guts Guts merged commit d83f286 into main Sep 4, 2024
24 checks passed
@Guts Guts deleted the fix/plugins-downloader-with-force-mode-enabled branch September 4, 2024 09:22
Guts added a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants