Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialDataPager: onLoad reinitialises the pager state, which is highly undesirable #13

Closed
Hoagiex opened this issue Nov 7, 2016 · 3 comments
Milestone

Comments

@Hoagiex
Copy link

Hoagiex commented Nov 7, 2016

Reattach/onLoad of the MaterialDataPager widget, should not lead to re-initialization on state on the pager.

if it has been previously attached, that state should be persistent, if the user navigates away from the page and later return to that page, if no new MaterialDataPager object needs to be constructed (example case: @singleton pages with Errai)

@kevzlou7979
Copy link
Contributor

@Hoagiex Thanks for catching this, I think what will be the solution is to do check on onLoad
Like for example :

@Override
public void onLoad() {
    if (!initialized) {
        // TODO the initialization method
        initialize();
        initialized = true;
    }
}

@kevzlou7979 kevzlou7979 added this to the 1.0 milestone Nov 7, 2016
@BenDol
Copy link
Contributor

BenDol commented Jun 16, 2017

Is this still happening in 2.0?

@BenDol
Copy link
Contributor

BenDol commented Jul 28, 2017

See #11

@BenDol BenDol closed this as completed Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants