Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to quit sniffnet using ctrl+q #68

Closed
roland-5 opened this issue Feb 10, 2023 · 7 comments
Closed

Add option to quit sniffnet using ctrl+q #68

roland-5 opened this issue Feb 10, 2023 · 7 comments
Labels
enhancement New feature, request, or improvement
Milestone

Comments

@roland-5
Copy link

roland-5 commented Feb 10, 2023

I would be very thankful if I could close sniffnet using keys combination: ctrl + q.

@GyulyVGC
Copy link
Owner

Is there a specific reason you should close it with shift+q instead of ctrl+q?
On which system are you running?

@roland-5 roland-5 changed the title Add option to quit sniffnet using shift+q Add option to quit sniffnet using ctrl+q Feb 10, 2023
@roland-5
Copy link
Author

roland-5 commented Feb 10, 2023

Damn, my bad. Yeah I should say ctrl+q, not shift. Corrected my mistake. Thanks.

@GyulyVGC
Copy link
Owner

No problem. If I recall correctly you already mentioned it in a past issue. So I assume you are still running on Linux.
I'll let you know you as soon as I have updates on this.

@roland-5
Copy link
Author

Yes, I use Linux (Arch Linux) with Sway (tiling window manager, so only keys shortcuts to close window). Take as much time as you need, and thanks for remembering me. New version is dope.

@GyulyVGC
Copy link
Owner

Oh, now I got your pain.
I will definitely try to do something for you.

@GyulyVGC
Copy link
Owner

Good news.
I just added the possibility to quit the app when Ctrl+Q is pressed.
It works on my system but if you do some tests as well it'd be awesome.
If you have Rust, you can clone the repo and build it locally.
I'll wait for your feedback before closing this issue.

@roland-5
Copy link
Author

Yup, it's working. thanks!

@GyulyVGC GyulyVGC added the enhancement New feature, request, or improvement label Feb 26, 2023
@GyulyVGC GyulyVGC added this to the v1.2.0 milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request, or improvement
Projects
None yet
Development

No branches or pull requests

2 participants