Assorted Warning Cleanup #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎖 |
zrax
requested changes
Sep 14, 2019
| int minNum = fNumBitVectors < other.fNumBitVectors ? fNumBitVectors : other.fNumBitVectors; | ||
| int i; | ||
| for( i = 0; i < minNum; i++ ) | ||
| uint32_t minNum = fNumBitVectors < other.fNumBitVectors ? fNumBitVectors : other.fNumBitVectors; |
There was a problem hiding this comment.
Do we want to include the algorithm header in this header? Presently, it is not included.
There was a problem hiding this comment.
Nah, probably not worth it here...
| lastParChunk = nullptr; | ||
| } else if(lastParChunk) { | ||
| size_t count = ((uintptr_t)c - (uintptr_t)start) / sizeof(wchar_t); // wchar_t is 2 bytes | ||
| lastParChunk->fText.assign(start, 0, count); |
This got a little out of hand from the initial warning cleanup. This should be a priority for ST::string-ification and perhaps std::unique_ptr-ification as well. For now, this makes life a lot easier by removing some warnings and stupid string copying.
Hoikas
force-pushed
the
warning_cleanup
branch
from
7a48f98
to
8fc0da3
Compare
|
Pushed fixes for all, save the one question re |
zrax
approved these changes
Sep 14, 2019
Hoikas
added a commit
to Hoikas/Plasma
that referenced
this pull request
Nov 11, 2019
Hoikas
added a commit
to Hoikas/Plasma
that referenced
this pull request
Nov 13, 2019
Hoikas
added a commit
that referenced
this pull request
Nov 14, 2019
Fix PBML parsing errors introduced in #595.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset attempts to silence and/or fix some of the warnings emitted during compilation. When I began, 406 warnings were being emitted in my build. It is now down to 313 warnings. I avoided fixing uninitialized members to prevent conflicts with #576.