-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted Warning Cleanup #595
Conversation
🎖 |
int minNum = fNumBitVectors < other.fNumBitVectors ? fNumBitVectors : other.fNumBitVectors; | ||
int i; | ||
for( i = 0; i < minNum; i++ ) | ||
uint32_t minNum = fNumBitVectors < other.fNumBitVectors ? fNumBitVectors : other.fNumBitVectors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::min
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to include the algorithm header in this header? Presently, it is not included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, probably not worth it here...
lastParChunk = nullptr; | ||
} else if(lastParChunk) { | ||
size_t count = ((uintptr_t)c - (uintptr_t)start) / sizeof(wchar_t); // wchar_t is 2 bytes | ||
lastParChunk->fText.assign(start, 0, count); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
This got a little out of hand from the initial warning cleanup. This should be a priority for ST::string-ification and perhaps std::unique_ptr-ification as well. For now, this makes life a lot easier by removing some warnings and stupid string copying.
7a48f98
to
8fc0da3
Compare
Pushed fixes for all, save the one question re |
Fix PBML parsing errors introduced in #595.
This changeset attempts to silence and/or fix some of the warnings emitted during compilation. When I began, 406 warnings were being emitted in my build. It is now down to 313 warnings. I avoided fixing uninitialized members to prevent conflicts with #576.