Fix hsMatrix44::DecompRigid()
quat decomposition.
#688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point,
hsQuat::FromMatrix44()
was changed to a static method, buthsMatrix44::DecompRigid()
was not updated and continued to use it as a member method. This resulted in the quaternion being discarded immediately.In the interest of preventing these sorts of bugs in the future, I added C++17's
[[nodiscard]]
attribute where it made sense inhsQuat
.Required by PhysX 4.1.