Entry Cameras for the Spawn Point Modifier #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a 1:1 implementation of how entry cameras are implemented in Doobes' Ages. The problem with this is that it assumes there is a single link-in point that we will always link into.
Deledrius
previously requested changes
Jan 14, 2024
Entry cameras need skinny detector boxes, not cubes. This allows the region to be exited with basically any movement.
This new python file modifier will disable all entry camera regions when the local player links in. That will prevent spurious entry cameras being used if there are multiple spawn points in the Age with entry cameras.
Deledrius
approved these changes
Jan 14, 2024
|
|
Hoikas
added a commit
that referenced
this pull request
Jun 23, 2024
... Somehow, this pull request was merged but isn't actually in the codebase. A force-push gone wrong???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplies the creation of "entry cameras" as seen in Doobes' Ages Veelay and Chiso. In Doobes' Ages, the entry cameras are pushed by entering into a region around the spawn point. When exiting the region, the camera is popped off and the region is disabled. Unfortunately, since this is a general purpose modifier, we cannot simply use that approach. That approach assumes there is a single spawn point for the entire Age. If you were to enter a second spawn point, then walk intgo the other spawn point's entry camera region, it would be spuriously triggered. Therefore, I have written a new
xEntryCam.pyscript for CWE to ensure that all entry cameras are disabled when the local player finishes linking in.See H-uru/Plasma#1556