Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUI popup's Post Effect FovX value #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DoobesURU
Copy link
Contributor

Small fix to adjust the FovX formula in the Post Effects Mod to make GUIs the proper width in-game.

@DoobesURU
Copy link
Contributor Author

So far, I have tested this fix on the several GUIs in Kirel and the few in BaronCityOffice and they all look correct with this new math.

Adjusts the X fov formula in the Post Effects Mod to make GUIs the proper width
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works, and seems to fix some horizontal compressing that happens with the default GUI cameras

@Hoikas
Copy link
Member

Hoikas commented Jul 8, 2024

I'm really curious why this fudge factor is needed. In my testing, it's unnesecary, and the max plugin doesn't do anything like this IIRC. It would be nice to have a blend file that I could look at to see what's going on... I would hate for us to merge this fudge factor to fix one case but break another when we should really be fetching this value from somewhere else.

@Jrius
Copy link
Collaborator

Jrius commented Jul 10, 2024

I don't know about MOUL, but at least for PotS this likely needs the same fix as regular cameras : widescreen fix. Cyan messed up their FOVs everywhere.
In PotS GUIs usually all have the same low FOV so the distortion isn't as noticeable but it's always been there. Drizzle's widescreen mod fixes this, and it makes the KI a bit rounder from what I remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants