L10n

[Deledrius]

These changes fix the file encoding on all files to fix exceptions in xKI.py when loading the game using a language other than English.

Also included is a fix to another python exception thrown when a text note is displayed on an imager containing non-ascii characters (such as the default Neighborhood Visitors note in French).

[diafero]

Is it necessary to add the BOM everywhere? Python should default to UTF-8, shouldn't it?

[Deledrius]

Back when I did this, I tested it both ways and there was something that had trouble without it. Can't recall what it was.

[dpogue]

I'd be more in favour of adding the "magic comment" to the top of every file rather than a BOM. Python defaults to ASCII, but adding the BOM causes issues with easy source browsing on github (unless the first commit is incorrect).

The magic comment:

# -*- coding: utf-8 -*-

[dpogue]

@Hoikas Can you take a look at 3dbffc9 and 0b4748d? I have a feeling you might have either already fixed these for unicode chat, or will at least know if they look correct.

[Hoikas]

Sure...

On a quick once over, we need to make sure that xCensor supports unicode objects (or just remove xCensor entirely because it sucks). The insertStringW function is the right way to go for unicode objects, fore sure. Also, we should be lowering the input chat message in xKI before we test it with the localized commands. My input branch causes the caps lock key to actually function correctly, so we need to handle all caps commands.

[diafero]

You mean the capslock now applies to the chat messages as well? IMHO that's a bug, it should not. I do not want to constantly turn it off and on if I want to run around, and not scream at people.

[Hoikas]

It's a bug when capslock doesn't make text in all caps. I can't be held responsible for Cyan's poor design decision to use caps lock as the runlock key.

[diafero]

Not, it is not, since caps lock is part of the game mechanics and is used to toggle "run always" mode. You/we may not be responsible for Cyan's design decisions, but we are responsible for at least not breaking existing functionality.

If you really want this, then please change the run mode key. I always have capslock enabled when I play Uru, since the avatar is way to slow otherwise, and I do not want to disable it for each chat message I send.

Making capslock "work" for text in-game makes things worse, not better. Technically it might be a fix, but from a user experience point of view, it's definitely not - user experience is (partially) broken by this change. And user experience always outweighs technical considerations the user just does not care about.