-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend overhaul #111
Backend overhaul #111
Conversation
@@ -0,0 +1,28 @@ | |||
import os, sys, glob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great idea and why doesn't carla do it already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I only recently realized we could do this and it makes the PYTHONPATH stuff a lot easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend naming the Docs/EgoVehicle.md file to be something like New/CustomEgo
README.md
Outdated
- See [`Signs.md`](Docs/Signs.md) to add custom in-world directional signs and spawn them | ||
- See [`LODs.md`](Docs/LODs.md) to learn about LOD modes for tuning your VR experience | ||
<!-- - See [`SetupVR.md`](Docs/SetupVR.md) to learn how to quickly and minimally set up VR with Carla --> | ||
- See [`Docs/Tutorials/`](Docs/Tutorials/) to view several DReyeVR tutorials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give a little preview:
See
Docs/Tutorials/
to view several DReyeVR tutorials to view several DReyeVR tutorials such as customizing the EgoVehicle, using our CustomActor API and others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- excellent work here @GustavoSilvera !
This is a large PR that includes various (mostly-backend) fixes and improvements. Listed in order of importance:
ConfigFile
class that is more flexible and lends itself better to splitting the parameters between general DReyeVR things and specific-vehicle params (like where the camera goes in each particular vehicle mesh). Also adds a recording/replay correctness warning by comparing the loaded config files with those that were used at the time of recording.__init__.py
startup script to ideally better load the DReyeVR files into the python path.