Correct usage of CMAKE_BUILD_TYPE #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Merge - To 1.12
Priority - 0. Blocker ⛔
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
hyoklee
reviewed
May 1, 2023
| set (HDF_BUILD_TYPE ${CMAKE_CFG_INTDIR}) | ||
| if (CMAKE_BUILD_TYPE) | ||
| set (HDF_CFG_NAME ${CMAKE_BUILD_TYPE}) | ||
| set (HDF_BUILD_TYPE ${CMAKE_BUILD_TYPE}) |
There was a problem hiding this comment.
Is the difference between HDF_CFG_NAME and HDF_BUILD_TYPE documented somewhere? Can we consolidate them?
There was a problem hiding this comment.
You're right, they should be documented, but aren't yet. I don't believe they can be combined, but will check.
There was a problem hiding this comment.
One of the things I was doing in the patch I was putting together included a comment block where I documented things like this. I think it's something that needs to be done, but I don't think that should hold this PR.
lrknox
approved these changes
May 1, 2023
derobins
approved these changes
May 1, 2023
|
This should fix #2791 |
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
May 17, 2023
Fixes a problem when using multi-config builds with the CMake GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.