Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many fixes to various compiler warnings #3124

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Many fixes to various compiler warnings #3124

merged 9 commits into from
Jun 19, 2023

Commits on Jun 16, 2023

  1. Fixed various -Wmissing-variable-declarations by adding static keyword 

    In a few cases, renamed the variable suffix from _g to _s.
    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    8c1da1a View commit details
    Browse the repository at this point in the history

  2. Fixed some -Wmissing-variable-declarations by using different declara… 

    …tion macros
    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1846298 View commit details
    Browse the repository at this point in the history

  3. Fixed various -Wconditional-uninitialized warnings by just initializi… 

    …ng variable to zero
    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    89ea464 View commit details
    Browse the repository at this point in the history

  4. Fixed various -Wcomma warnings

    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    8c393ea View commit details
    Browse the repository at this point in the history

  5. Fixed clang -Wstrict-prototypes warnings

    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    baa05f0 View commit details
    Browse the repository at this point in the history

  6. Fixed various -Wunused-variable warnings 

    Some of these the compiler is now able to identify thanks to the previous fixes of -Wmissing-variable-declarations warnings, making the variables static.
    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    bdd115b View commit details
    Browse the repository at this point in the history

  7. Updated some casts to fix the only 3 -Wcast-qual warnings

    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    3b3be07 View commit details
    Browse the repository at this point in the history

  8. Fixed the only -Wsometimes-uninitialized warning 

    Moved the logging into the `if`, which I think is what the author probably intended.
    @seanm
    seanm committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    2912b38 View commit details
    Browse the repository at this point in the history

  9. Committing clang-format changes

    @github-actions
    github-actions[bot] committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    f578b00 View commit details
    Browse the repository at this point in the history