H5TS_win32_thread_exit #396
Conversation
byrnHDF
requested review from
bmribler,
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
| = TLS_OUT_OF_INDEXES | ||
| #endif | ||
| ; | ||
| #endif /* H5_HAVE_CODESTACK */ |
There was a problem hiding this comment.
Definitely not a fan of this format. I'd just duplicate the variable declaration, as is done below.
There was a problem hiding this comment.
I missed that one - but with 4 instances it was way too busy and the formatter insisted on tabs making it look wierder.
There was a problem hiding this comment.
I think the problem I had was the original had some comments that just made it looked messy!
Updated with better.
There was a problem hiding this comment.
Is the static attribute okay? I think I accidentally used the H5TS_key_t H5TS_cancel_key_s section as a template.
There was a problem hiding this comment.
Never mind - the action check told me!
There was a problem hiding this comment.
okay format is weird - but that's what it wants.
|
I can do which ever you prefer. |
This is the PR to replace #359.
Plus h5dump gen 1.6 API fix.